[FLINK-8759] Prepare LengthFieldBasedFrameDecoder for Netty upgrade

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.6.0
• Component/s: Runtime / Network
• Assignee: Nico Kruber
• Reporter: Nico Kruber
• Created: 23/Feb/18 11:21
• Updated: 12/Jun/18 09:47
• Resolved: 12/Jun/18 09:45

Description

For a bug in Netty's shutdown sequence and overall improvements in Netty, I'd like to bump the version (and stay within the 4.0 series for now). The problem we faced in the past should not be relevant for credit-based flow control anymore and can be worked around (for the fallback code path) by restoring LengthFieldBasedFrameDecoder's old behaviour of copying contents to new buffers instead of slicing the existing one (please refer to FLINK-7428 for the inverse direction).

Issue Links

• is related to: FLINK-4387 Instability in KvStateClientTest.testClientServerIntegration()
• is superceded by: FLINK-3952 Bump Netty to 4.1
• relates to: FLINK-8893 NPE when netty try to allocate directBuffer
• supercedes: FLINK-7428 avoid one additional buffer copy when receiving messages
• links to: GitHub Pull Request #5571