Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-7315 use flink's buffers in netty
  3. FLINK-7428

avoid one additional buffer copy when receiving messages

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Won't Do
    • 1.4.0
    • None
    • Runtime / Network
    • None

    Description

      By using LengthFieldBasedFrameDecoder, we create one unnecessary (netty) buffer copy in this class which could be easily avoided since we can ensure that the buffer is free to be released after decoding it in the NettyMessageDecoder and into our own buffer and/or events.

      The solution would be to make NettyMessageDecoder extend from LengthFieldBasedFrameDecoder and handle the decoding of the frames and the objects in there. In the frame creation otherwise done by LengthFieldBasedFrameDecoder, we could use a sliced buffer instead. This solution also makes the channel pipelines a bit simpler.

      Attachments

        Issue Links

          Activity

            People

              nkruber Nico Kruber
              nkruber Nico Kruber
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: