[FLINK-35454] Connector ArchTests fails due to dependency on fink.util.Preconditions

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.20.0
• Fix Version/s: 1.20.0
• Component/s: Test Infrastructure
• Labels: pull-request-available
• Assignee: Ahmed Hamdy
• Reporter: Ahmed Hamdy
• Created: 26/May/24 08:37
• Updated: 28/May/24 22:38
• Resolved: 28/May/24 22:38

Description

Description

• Arch Unit Rules for connectors limits dependencies of any classes in connectors on @Public or @PublicEvolving with exceptions of connector package classes, this is not true since we should be able to depend on internal util classes like Preconditions and ExceptionsUtils

freeze(
                    javaClassesThat(resideInAnyPackage(CONNECTOR_PACKAGES))
                            .and()
                            .areNotAnnotatedWith(Deprecated.class)
                            .should()
                            .onlyDependOnClassesThat(
                                  areFlinkClassesThatResideOutsideOfConnectorPackagesAndArePublic()
                                            .or(
                                                    JavaClass.Predicates.resideOutsideOfPackages(
                                                            "org.apache.flink.."))
                                            .or(
                                                    JavaClass.Predicates.resideInAnyPackage(
                                                            CONNECTOR_PACKAGES)) )
                            .as(
                                    "Connector production code must depend only on public API when outside of connector packages"));

Issue Links

• links to: GitHub Pull Request #24843