[FLINK-35454] Connector ArchTests fails due to dependency on fink.util.Preconditions - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 1.20.0
Fix Version/s: 1.20.0
Component/s: Test Infrastructure
Labels:
- pull-request-available

Description

Arch Unit Rules for connectors limits dependencies of any classes in connectors on @Public or @PublicEvolving with exceptions of connector package classes, this is not true since we should be able to depend on internal util classes like Preconditions and ExceptionsUtils

freeze(
                    javaClassesThat(resideInAnyPackage(CONNECTOR_PACKAGES))
                            .and()
                            .areNotAnnotatedWith(Deprecated.class)
                            .should()
                            .onlyDependOnClassesThat(
                                  areFlinkClassesThatResideOutsideOfConnectorPackagesAndArePublic()
                                            .or(
                                                    JavaClass.Predicates.resideOutsideOfPackages(
                                                            "org.apache.flink.."))
                                            .or(
                                                    JavaClass.Predicates.resideInAnyPackage(
                                                            CONNECTOR_PACKAGES)) )
                            .as(
                                    "Connector production code must depend only on public API when outside of connector packages"));