[FLINK-11120] TIMESTAMPADD function handles TIME incorrectly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.9.2, 1.10.0
• Component/s: Table SQL / Planner
• Labels: pull-request-available
• Assignee: Forward Xu
• Reporter: Forward Xu
• Created: 10/Dec/18 10:57
• Updated: 29/Jan/20 09:01
• Resolved: 07/Dec/19 18:40

Description

The error occur when timestampadd(MINUTE, 1, time '01:00:00') is executed:

java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.Long

at org.apache.calcite.rex.RexBuilder.clean(RexBuilder.java:1520)
at org.apache.calcite.rex.RexBuilder.makeLiteral(RexBuilder.java:1318)
at org.apache.flink.table.codegen.ExpressionReducer.reduce(ExpressionReducer.scala:135)
at org.apache.calcite.rel.rules.ReduceExpressionsRule.reduceExpressionsInternal(ReduceExpressionsRule.java:620)
at org.apache.calcite.rel.rules.ReduceExpressionsRule.reduceExpressions(ReduceExpressionsRule.java:540)
at org.apache.calcite.rel.rules.ReduceExpressionsRule$ProjectReduceExpressionsRule.onMatch(ReduceExpressionsRule.java:288)

I think it should meet the following conditions:

expression	Expect the result
timestampadd(MINUTE, -1, time '00:00:00')	23:59:00
timestampadd(MINUTE, 1, time '00:00:00')	00:01:00
timestampadd(MINUTE, 1, time '23:59:59')	00:00:59
timestampadd(SECOND, 1, time '23:59:59')	00:00:00
timestampadd(HOUR, 1, time '23:59:59')	00:59:59

This problem seems to be a bug in calcite. I have submitted isuse to calcite. The following is the link.
CALCITE-2699

Issue Links

• is a clone of: FLINK-10994 The bug of timestampadd handles time
• is duplicated by: FLINK-10994 The bug of timestampadd handles time
• links to: GitHub Pull Request #8746