[CALCITE-2699] TIMESTAMPADD function handles TIME incorrectly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.17.0
• Fix Version/s: 1.18.0
• Component/s: core
• External issue URL: https://github.com/apache/calcite/pull/936
• Assignee: Julian Hyde
• Reporter: Forward Xu
• Created: 23/Nov/18 06:55
• Updated: 23/Dec/18 00:11
• Resolved: 02/Dec/18 02:33

Description

Two errors occur when timestampadd(MINUTE, 1, time '01:00:00') is executed:

1. The return result can only be of TimeStamp type and is expected to be of Time type
2. The return value is 1970-01-01 01:01:00, and the expectation is 01:01:00
3. I think it should meet the following conditions:

expression	Expect the result
timestampadd(MINUTE, -1, time '00:00:00')	23:59:00
timestampadd(MINUTE, 1, time '00:00:00')	00:01:00
timestampadd(MINUTE, 1, time '23:59:59')	00:00:59
timestampadd(SECOND, 1, time '23:59:59')	00:00:00
timestampadd(HOUR, 1, time '23:59:59')	00:59:59
timestampadd(DAY, -1, time '23:59:59')	23:59:59
timestampadd(WEEK, -1, time '23:59:59')	23:59:59
timestampadd(MONTH, -1, time '23:59:59')	23:59:59
timestampadd(QUARTER, -1, time '23:59:59')	23:59:59
timestampadd(YEAR, -1, time '23:59:59')	23:59:59