[FINERACT-1233] Client Java SDK operations with LocalDate (and other date types) in Request shouldn't also require a dateFormat and locale in the request

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Auto Closed
• Component/s: SDK
• Labels: Cleanup2022
• Assignee: Unassigned
• Reporter: Michael Vorburger
• Created: 21/Oct/20 00:50
• Updated: 07/Nov/22 18:11
• Resolved: 07/Nov/22 18:11

Description

Requests such as POST /offices have e.g. an openingDate which is of Java type LocalDate.

Due to https://demo.fineract.dev/fineract-provider/api-docs/apiLive.htm#dates_and_numbers, a user of the Java Client has to also specify a dateFormat("yyyy-mm-dd") AND a locale("en_US"). From a Java API point of view, this doesn't really make much sense. (Because if it's a strong type, the implementation should serialize it however it sees fit; asking the user to specify the Date Format, but have the implementation provide the Serialization, mixes up layers of responsibility.)

I'm not sure how to best address this. For the short term, I'll at least introduce a DATE_FORMAT = "yyyy-mm-dd" constant in FineractClient which can be used.

PS: Date types are not consistent in the client, see FINERACT-1232.

Issue Links

• is related to: FINERACT-1234 Client Java SDK must configure GSON to serialize yyyy-mm-dd date format
• relates to: FINERACT-1232 Client Java SDK date types are inconsistent (LocalDate VS String)