Uploaded image for project: 'Apache Fineract'
  1. Apache Fineract
  2. FINERACT-1230

SDK Swagger Client Java API mixes Long and Integer for IDs

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.7.0
    • SDK
    • None

    Description

      It seems to me that the code generated from our OpenAPI Swagger metadata mixes up Long and Integer for IDs somewhere.

      For example, if in org.apache.fineract.client.services.DocumentsApi.getDocument(String, Long, Long) the entity ID is Long, why does GetClientsResponse have an Integer getId()...

      We IMHO should just use Long everywhere for everything, in the API (even if in the implementation it's still Integer).

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            aleks Aleksandar Vidakovic
            vorburger Michael Vorburger
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment