Uploaded image for project: 'Apache Fineract'
  1. Apache Fineract
  2. FINERACT-1175

Fix spm.repository / spm.domain JPA bug (?), and simplify appContext.xml

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5.0
    • Component/s: None
    • Labels:
      None

      Description

      While I was working on FINERACT-1127, I've noticed that appContext.xml individually lists 10+ packages.. why not just use org.apache.fineract.** ?

      There is also a fineract-provider/src/main/resources/META-INF/spring/spmContext.xml, which seems weird.. why is that, and only that, in a separate file, instead of listed in appContext.xml? Would seem more consistent to have all in one.

      Most importantly, perhaps, the <jpa:repositories base-package="org.apache.fineract.spm.repository"/> in spmContext.xml seems inconsistent with appContext.xml.. shouldn't that be org.apache.fineract.spm.domain, instead? Or are the other ones wrong? (And this is another reason why having them all together in a single place seems easier, to see differences.)

      Petri Tuomola Aleksandar Vidakovic do you perhaps have any thoughts about this?

      Yemdjih Kaze Nasser (Yemdjih Kaze Nasser ?) I'm not sure if this is something that particularly interests you, in the context of the OpenJPA to EclipseLink migration, but I thought I would just mention it here FYI, and on the off chance that this is causing you any issues during that project.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vorburger Michael Vorburger
                Reporter:
                vorburger Michael Vorburger
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: