[FINERACT-1175] Fix spm.repository / spm.domain JPA bug (?), and simplify appContext.xml

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Assignee: Michael Vorburger
• Reporter: Michael Vorburger
• Created: 05/Oct/20 09:42
• Updated: 25/Feb/21 08:10
• Resolved: 11/Oct/20 19:45

Description

While I was working on FINERACT-1127, I've noticed that appContext.xml individually lists 10+ packages.. why not just use org.apache.fineract.** ?

There is also a fineract-provider/src/main/resources/META-INF/spring/spmContext.xml, which seems weird.. why is that, and only that, in a separate file, instead of listed in appContext.xml? Would seem more consistent to have all in one.

Most importantly, perhaps, the <jpa:repositories base-package="org.apache.fineract.spm.repository"/> in spmContext.xml seems inconsistent with appContext.xml.. shouldn't that be org.apache.fineract.spm.domain, instead? Or are the other ones wrong? (And this is another reason why having them all together in a single place seems easier, to see differences.)

ptuomola aleks do you perhaps have any thoughts about this?

xurror (kaze ?) I'm not sure if this is something that particularly interests you, in the context of the OpenJPA to EclipseLink migration, but I thought I would just mention it here FYI, and on the off chance that this is causing you any issues during that project.

Issue Links

• Blocked: FINERACT-1305 Release Apache Fineract v1.5.0
• relates to: FINERACT-1127 Modularize Fineract to allow something like e.g. the Pentaho integration to be built and run separately
• links to: GitHub Pull Request #1392