[FELIX-4719] SnapshotCommand never properly restores archived data-areas

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: deploymentadmin-0.9.8
• Component/s: Deployment Admin
• Assignee: J.W. Janssen
• Reporter: J.W. Janssen
• Created: 04/Dec/14 12:09
• Updated: 16/Jan/16 15:03
• Resolved: 05/Dec/14 09:21

Description

The RestoreSnapshotRunnable task that is used by SnapshotCommand to restore the data area of a bundle cannot ever work:

private void unpack(File source, File target) throws IOException {
  ZipInputStream input = null;
  try {
    input = new ZipInputStream(new FileInputStream(source));
    for (ZipEntry entry = input.getNextEntry(); entry != null; entry = input.getNextEntry()) {
      if (entry.isDirectory()) {
        (new File(target, entry.getName())).mkdirs();
      } else {
        OutputStream output = null;
        try {
          output = new FileOutputStream(target);
// THIS:                                ^^^^^^
// ...

Given that target is always a directory, the marked line above will never succeed.

Issue Links

• is related to: ACE-500 Exception when updating tag value used in MetaType configuration file