[ACE-500] Exception when updating tag value used in MetaType configuration file

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.1
• Fix Version/s: 2.1.0
• Assignee: J.W. Janssen
• Reporter: Bram Pouwelse
• Created: 04/Dec/14 16:33
• Updated: 30/Jan/16 19:38
• Resolved: 18/Jan/15 20:46

Description

When I update a tag value which is used in a MetaType configuration file. I get an exception (stacktrace below) on the target , after the failed deployment the target configuration is not updated.

[INFO] 16:27:02 (controller) Installing streaming deployment update 4.0.0 => 5.0.0
[DEBUG] 16:27:02 (discovery) Returning cached serverURL: http://localhost:8181
[WARNING] 16:27:02 (deployment) Failed to restore snapshot!
java.io.FileNotFoundException: /Users/brampouwelse/Development/git-repos/org.apache.ace/run-target/bundle-cache/bundle24/data (Is a directory)
	at java.io.FileOutputStream.open(Native Method)
	at java.io.FileOutputStream.<init>(FileOutputStream.java:213)
	at java.io.FileOutputStream.<init>(FileOutputStream.java:162)
	at org.apache.felix.deploymentadmin.spi.SnapshotCommand$RestoreSnapshotRunnable.unpack(SnapshotCommand.java:187)
	at org.apache.felix.deploymentadmin.spi.SnapshotCommand$RestoreSnapshotRunnable.doRun(SnapshotCommand.java:154)
	at org.apache.felix.deploymentadmin.spi.AbstractAction.run(AbstractAction.java:34)
	at org.apache.felix.deploymentadmin.spi.Command.rollback(Command.java:90)
	at org.apache.felix.deploymentadmin.spi.DeploymentSessionImpl.rollback(DeploymentSessionImpl.java:97)
	at org.apache.felix.deploymentadmin.spi.DeploymentSessionImpl.call(DeploymentSessionImpl.java:83)
	at org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:214)
	at org.apache.ace.agent.impl.DeploymentHandlerImpl.install(DeploymentHandlerImpl.java:237)
	at org.apache.ace.agent.impl.DefaultController$StreamingUpdateInstaller.doInstallUpdate(DefaultController.java:162)
	at org.apache.ace.agent.impl.DefaultController$UpdateInstaller.installUpdate(DefaultController.java:253)
	at org.apache.ace.agent.impl.DefaultController.runDeploymentUpdate(DefaultController.java:610)
	at org.apache.ace.agent.impl.DefaultController.run(DefaultController.java:460)
	at org.apache.ace.agent.impl.AgentContextImpl$1.run(AgentContextImpl.java:252)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
[ERROR] 16:27:02 (controller) Installation of deployment update failed: Command failed! (463)!
java.lang.IllegalArgumentException: Trying to begin new deployment session while already in one.
	at org.apache.felix.deployment.rp.autoconf.AutoConfResourceProcessor.begin(AutoConfResourceProcessor.java:97)
	at org.apache.felix.deploymentadmin.spi.ProcessResourceCommand.doExecute(ProcessResourceCommand.java:98)
	at org.apache.felix.deploymentadmin.spi.Command.execute(Command.java:55)
	at org.apache.felix.deploymentadmin.spi.DeploymentSessionImpl.call(DeploymentSessionImpl.java:77)
	at org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:214)
	at org.apache.ace.agent.impl.DeploymentHandlerImpl.install(DeploymentHandlerImpl.java:237)
	at org.apache.ace.agent.impl.DefaultController$StreamingUpdateInstaller.doInstallUpdate(DefaultController.java:162)
	at org.apache.ace.agent.impl.DefaultController$UpdateInstaller.installUpdate(DefaultController.java:253)
	at org.apache.ace.agent.impl.DefaultController.runDeploymentUpdate(DefaultController.java:610)
	at org.apache.ace.agent.impl.DefaultController.run(DefaultController.java:460)
	at org.apache.ace.agent.impl.AgentContextImpl$1.run(AgentContextImpl.java:252)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
[DEBUG] 16:27:02 (controller) Sync completed...

Issue Links

• relates to: FELIX-4718 SnapshotCommand creates invalid snapshot archives
• relates to: FELIX-4719 SnapshotCommand never properly restores archived data-areas