[DRILL-8240] Revisit clone of log4j Strings class

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.20.1
• Fix Version/s: 1.21.0
• Component/s: Functions - Hive
• Assignee: Unassigned
• Reporter: PJ Fanning
• Created: 29/May/22 08:59
• Updated: 15/Aug/23 11:35
• Resolved: 15/Aug/23 11:35

Description

See https://issues.apache.org/jira/browse/DRILL-8044 for background.

The code added there is now out of date. After the log4j panic late last year, 5 commits were made to modify the real log4j class and these are missing from the Drill copy.

Compare https://github.com/apache/logging-log4j2/commits/rel/2.17.2/log4j-api/src/main/java/org/apache/logging/log4j/util/Strings.java to https://github.com/apache/logging-log4j2/commits/rel/2.14.1/log4j-api/src/main/java/org/apache/logging/log4j/util/Strings.java

The Drill copy is based on Log4J 2.14.1. Every commit in 2021 and 2022 is missing from the Drill copy.

Issue Links

• relates to: DRILL-8044 Remove/Update contrib/storage-hive copy of log4j Strings.java
• relates to: HIVE-26272 Inline util code that is used from log4j jar