[DRILL-8044] Remove/Update contrib/storage-hive copy of log4j Strings.java

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.19.0
• Fix Version/s: 1.20.0
• Component/s: Storage - Hive
• Assignee: Unassigned
• Reporter: PJ Fanning
• Created: 15/Nov/21 13:17
• Updated: 29/May/22 09:21
• Resolved: 29/May/22 07:09

Description

https://github.com/apache/drill/blob/master/contrib/storage-hive/core/src/main/java/org/apache/logging/log4j/util/Strings.java is a copy of the real Log4j class but causes issues for Apache POI Excel code that relies on the latest Log4j code.

Apache POI started using log4j 2.x in POI 5.1.0.

This issue was originally reported at https://github.com/apache/drill/issues/2373

 

Describe the solution you'd like

If this class is really necessary, could you consider updating it to match the latest Log4j code? As long as Drill keeps its own copy of this Strings class, it is likely to regularly hit issues with being incompatible with latest log4j releases.

https://issues.apache.org/jira/browse/HIVE-23088 is marked as fixed in recent Hive releases - so ideally, Drill team should remove the copy of the Strings class in Drill contrib/storage-hive. I can only find Hive 3.1.2 in Maven Central (this doesn't have the HIVE-23088 fix) - so I'm not really sure what Apache Hive team are doing with the release numbers.

If you really need to keep the copy of the log4j Strings class, the latest log4j release code seems safe in that it is self-contained (other than using core Java code).

https://github.com/apache/logging-log4j2/blob/rel/2.14.1/log4j-api/src/main/java/org/apache/logging/log4j/util/Strings.java

Issue Links

• is related to: DRILL-8240 Revisit clone of log4j Strings class
• relates to: DRILL-8033 uptake POI 5.1.0