[DRILL-6611] Add [meta]-[Enter] js handler for query form submission - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.14.0
Fix Version/s: 1.15.0
Component/s: Web Server
Labels:
- doc-complete
- ready-to-commit

Description

The new ACE-based SQL query editor is great. Being able to submit the form without using a mouse would be even better.

Adding:

document.getElementById('queryForm')
 .addEventListener('keydown', function(e) {
 if (!(e.keyCode == 13 && e.metaKey)) return;
 if (e.target.form) doSubmitQueryWithUserName();
});

to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such support.

I can file a PR with the code if desired.

------

Functionality (for the documentation):

This JIRA's commit introduces the following to Drill:

When composing queries in the web query editor it is now possible to submit the query text by using the Meta+Enter key combination. This will trigger the same action as pressing the Submit button. On Mac keyboards Meta+Enter is Cmd+Enter. On Windows or Linux is Ctrl+Enter though Linux users may have keymapped the Meta key to another physical keyboard key.