[DRILL-6611] Add [meta]-[Enter] js handler for query form submission

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.14.0
• Fix Version/s: 1.15.0
• Component/s: Web Server
• Labels: doc-complete ready-to-commit
• Assignee: Kunal Khatua
• Reporter: Bob Rudis
• Reviewer: Arina Ielchiieva
• Created: 14/Jul/18 18:57
• Updated: 28/Dec/18 07:36
• Resolved: 06/Nov/18 11:56

Description

The new ACE-based SQL query editor is great. Being able to submit the form without using a mouse would be even better.

Adding:

 

document.getElementById('queryForm')
 .addEventListener('keydown', function(e) {
 if (!(e.keyCode == 13 && e.metaKey)) return;
 if (e.target.form) doSubmitQueryWithUserName();
});

to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such support.

I can file a PR with the code if desired.

------

Functionality (for the documentation):

This JIRA's commit introduces the following to Drill:

When composing queries in the web query editor it is now possible to submit the query text by using the Meta+Enter key combination. This will trigger the same action as pressing the Submit button. On Mac keyboards Meta+Enter is Cmd+Enter. On Windows or Linux is Ctrl+Enter though Linux users may have keymapped the Meta key to another physical keyboard key.

Issue Links

• is related to: DRILL-6933 Ctrl+Enter meta combo not working on Windows & mac OS
• links to: GitHub Pull Request #1392
• links to: GitHub Pull Request #1521