[DRILL-3366] Short circuit of OR expression causes incorrect partitioning

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Component/s: Execution - Codegen
• Assignee: Steven Phillips
• Reporter: Steven Phillips
• Created: 25/Jun/15 02:47
• Updated: 14/Jan/16 18:34
• Resolved: 14/Jan/16 18:34

Description

CTAS partitioning relies on evaluating the expression newPartitionValue(column A) || newPartitionValue(column B) || ..

to determine if there is a new partition should start. The "newPartitionValue" function returns true if the current value of the expression is different from the previous value. The function holds some state in the workspace (the previous value), and thus needs to be evaluated every time. Short circuit expression evaluation causes this to not be the case.