Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-3366

Short circuit of OR expression causes incorrect partitioning

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: Execution - Codegen
    • Labels:
      None

      Description

      CTAS partitioning relies on evaluating the expression newPartitionValue(column A) || newPartitionValue(column B) || ..

      to determine if there is a new partition should start. The "newPartitionValue" function returns true if the current value of the expression is different from the previous value. The function holds some state in the workspace (the previous value), and thus needs to be evaluated every time. Short circuit expression evaluation causes this to not be the case.

        Attachments

        1. DRILL-3366.patch
          3 kB
          Steven Phillips

          Activity

            People

            • Assignee:
              sphillips Steven Phillips
              Reporter:
              sphillips Steven Phillips
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: