Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-1896

Unit tests failing due to string based comparison at JsonStringHashMap & JsonStringArrayList #equals methods

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.8.0
    • None
    • None

    Description

      Unit test framework relies on JsonString*#equals methods to compare actual and expected results. We should properly implement these to prevent unit tests from failing.

      Attachments

        1. DRILL-1896.patch
          40 kB
          Jason Altekruse
        2. DRILL-1896-v3.patch
          41 kB
          Jason Altekruse
        3. RILL-1896-v2.patch
          40 kB
          Jason Altekruse

        Issue Links

        causes

        Improvement - An improvement or enhancement to an existing feature or task. DRILL-1824 Certain JSON data test patterns cause false negatives in new test framework

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Resolved
        is fixed by

        Bug - A problem which impairs or prevents the functions of the product. DRILL-8046 Enabling ignored test cases for SchemaChange

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Resolved

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            vitalii Vitalii Diravka
            hgunes Hanifi Gunes
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment