[DRILL-1824] Certain JSON data test patterns cause false negatives in new test framework

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Done
• Affects Version/s: 0.7.0
• Fix Version/s: 1.19.0
• Component/s: Tools, Build & Test
• Assignee: Vitalii Diravka
• Reporter: Jacques Nadeau
• Created: 08/Dec/14 06:31
• Updated: 14/Nov/21 22:57
• Resolved: 14/Nov/21 22:57

Description

Testing the json reader.

    testBuilder() //
      .sqlQuery("select b from files") //
      .unOrdered() //
      .jsonBaselineFile("expected.json") //
      .build()
      .run();

Files composed of two files:

File 1

{"a": "foo","b": null}
{"a": "bar","b": null}

File 2

{"a": "foo2","b": null}
{"a": "bar2","b": {"x":1, "y":2}}

Expected Output:

b
null
null
{}
{"x":1,"y":2}

Receives failure of

java.lang.Exception: Did not find expected record in result set: `b` : null, 

	at org.apache.drill.DrillTestWrapper.compareResults(DrillTestWrapper.java:528)
	at org.apache.drill.DrillTestWrapper.compareUnorderedResults(DrillTestWrapper.java:290)
	at org.apache.drill.DrillTestWrapper.run(DrillTestWrapper.java:118)
	at org.apache.drill.exec.vector.complex.writer.TestJsonReader.schemaChange(TestJsonReader.java:60)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:601)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:601)

Issue Links

• is caused by: DRILL-1896 Unit tests failing due to string based comparison at JsonStringHashMap & JsonStringArrayList #equals methods