Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Flags:
      Patch

      Description

      Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much modernization is possible, even if we maintain CMake 2.8 compatibility, and that modernization is beneficial for overall sanity of the build code, as the example of Qpid Proton project shows. [2], [3]

      RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake 2.8.12.2. Therefore, the first step would be to change minimum required version from 2.6.2 to this.

          cmake_minimum_required(VERSION 2.8.12)
      

      The indentation changes are of course harmless in any case and easy to make. I am not eager to bundle the whitespace change, as it is disruptive to merging work in progress (if git not configured to ignore whitespace).

      [1] https://github.com/apache/qpid-dispatch/pull/288
      [2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake modularity - split out library detection code
      [3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it uses the easier to use imported target feature

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                jdanek Jiri Daněk
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: