[DISPATCH-1268] Use more modern idiomatic cmake

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Incomplete
• Fix Version/s: 1.13.0
• Flags: Patch
• Assignee: Jiri Daněk
• Reporter: Jiri Daněk
• Created: 16/Feb/19 12:03
• Updated: 01/Feb/21 10:25
• Resolved: 25/Jul/20 12:34

Description

Dismissing the whole CMake modernization PR [1] is IMO too harsh. Much modernization is possible, even if we maintain CMake 2.8 compatibility, and that modernization is beneficial for overall sanity of the build code, as the example of Qpid Proton project shows. [2], [3]

RHEL 6.10 bundles cmake 2.8.12.2-4.el6 and RHEL 7.6 also has cmake 2.8.12.2. Therefore, the first step would be to change minimum required version from 2.6.2 to this.

    cmake_minimum_required(VERSION 2.8.12)

The indentation changes are of course harmless in any case and easy to make. I am not eager to bundle the whitespace change, as it is disruptive to merging work in progress (if git not configured to ignore whitespace).

[1] https://github.com/apache/qpid-dispatch/pull/288
[2] https://issues.apache.org/jira/browse/PROTON-1878 Improve cmake modularity - split out library detection code
[3] https://issues.apache.org/jira/browse/PROTON-1879 Update cmake so that it uses the easier to use imported target feature

Issue Links

• is cloned by: DISPATCH-1942 Use modern idiomatic cmake 3.x
• links to: GitHub Pull Request #449