Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.11.1.1
    • Fix Version/s: 10.11.1.1
    • Component/s: Documentation
    • Labels:
      None
    • Urgency:
      Normal

      Description

      The MERGE statement is ready to be documented. Hopefully, the functional spec attached to DERBY-3155 is complete enough for this task.

      1. rrefsqljmerge.html
        13 kB
        Kim Haase
      2. DERBY-6526-upgrade.diff
        1.0 kB
        Kim Haase
      3. DERBY-6526-2.zip
        6 kB
        Kim Haase
      4. DERBY-6526-2.diff
        12 kB
        Kim Haase
      5. DERBY-6526.zip
        6 kB
        Kim Haase
      6. DERBY-6526.stat
        0.1 kB
        Kim Haase
      7. DERBY-6526.diff
        11 kB
        Kim Haase

        Issue Links

          Activity

          Hide
          Kim Haase added a comment -

          Thanks for the great spec, Rick – it made this task pretty easy.

          Attaching DERBY-6526.diff, DERBY-6526.stat, and DERBY-6526.zip, with changes as follows:

          A src/ref/rrefsqljmerge.dita
          M src/ref/rrefkeywords29722.dita
          M src/ref/refderby.ditamap

          Please let me know what changes are needed.

          Show
          Kim Haase added a comment - Thanks for the great spec, Rick – it made this task pretty easy. Attaching DERBY-6526 .diff, DERBY-6526 .stat, and DERBY-6526 .zip, with changes as follows: A src/ref/rrefsqljmerge.dita M src/ref/rrefkeywords29722.dita M src/ref/refderby.ditamap Please let me know what changes are needed.
          Hide
          Rick Hillegas added a comment -

          Thanks for the patch, Kim. A couple comments:

          rrefkeywords29722:

          o MERGE and MATCHED are non-reserved keywords, so they should not appear in this list.

          o While I was in there, I discovered some other problems with this page:

          OVER and ROW_NUMBER are non-reserved too, so they shouldn't appear in this list

          CHARACTER_LENGTH and LEADING are reserved keywords which should appear in this list

          rrefsqljmerge

          o I see that the functional spec incorrectly describes the restrictions on identity and generated columns. I will update the spec to say this: INSERT column lists may not mention identity columns. In a VALUES clause, DEFAULT is the only value allowed for generated columns. On the right side of SET operators for UPDATE actions, DEFAULT is the only value allowed for generated and identity columns.

          o I think it would be good to state somewhere that the row count for a successful MERGE statement is the total number of rows inserted, updated, and deleted by the statement.

          Thanks
          -Rick

          Show
          Rick Hillegas added a comment - Thanks for the patch, Kim. A couple comments: rrefkeywords29722: o MERGE and MATCHED are non-reserved keywords, so they should not appear in this list. o While I was in there, I discovered some other problems with this page: OVER and ROW_NUMBER are non-reserved too, so they shouldn't appear in this list CHARACTER_LENGTH and LEADING are reserved keywords which should appear in this list rrefsqljmerge o I see that the functional spec incorrectly describes the restrictions on identity and generated columns. I will update the spec to say this: INSERT column lists may not mention identity columns. In a VALUES clause, DEFAULT is the only value allowed for generated columns. On the right side of SET operators for UPDATE actions, DEFAULT is the only value allowed for generated and identity columns. o I think it would be good to state somewhere that the row count for a successful MERGE statement is the total number of rows inserted, updated, and deleted by the statement. Thanks -Rick
          Hide
          Kim Haase added a comment -

          Thanks so much, Rick! Here is a second pass, DERBY-6526-2.diff and DERBY-6526-2.zip. I hope I guessed right on how the fixes applied to updates and inserts.

          Show
          Kim Haase added a comment - Thanks so much, Rick! Here is a second pass, DERBY-6526 -2.diff and DERBY-6526 -2.zip. I hope I guessed right on how the fixes applied to updates and inserts.
          Hide
          Rick Hillegas added a comment -

          Thanks, Kim. Looks great to me. +1

          Show
          Rick Hillegas added a comment - Thanks, Kim. Looks great to me. +1
          Hide
          ASF subversion and git services added a comment -

          Commit 1583446 from Kim Haase in branch 'docs/trunk'
          [ https://svn.apache.org/r1583446 ]

          DERBY-6526 Document the MERGE statement

          Added a new Reference Manual topic and modified another topic as well as the map file.

          Patch: DERBY-6526-2.diff

          Show
          ASF subversion and git services added a comment - Commit 1583446 from Kim Haase in branch 'docs/trunk' [ https://svn.apache.org/r1583446 ] DERBY-6526 Document the MERGE statement Added a new Reference Manual topic and modified another topic as well as the map file. Patch: DERBY-6526 -2.diff
          Hide
          Kim Haase added a comment -

          Thanks, Rick!

          Committed patch DERBY-6526-2.diff to documentation trunk at revision 1583446.

          Show
          Kim Haase added a comment - Thanks, Rick! Committed patch DERBY-6526 -2.diff to documentation trunk at revision 1583446.
          Hide
          Kim Haase added a comment -

          Reopening to add full-upgrade information.

          Show
          Kim Haase added a comment - Reopening to add full-upgrade information.
          Hide
          Kim Haase added a comment -

          Attaching DERBY-6526-upgrade.diff and rrefsqljmerge.html, with the upgrade information added to

          M src/ref/rrefsqljmerge.dita

          Hope it's okay. Thanks.

          Show
          Kim Haase added a comment - Attaching DERBY-6526 -upgrade.diff and rrefsqljmerge.html, with the upgrade information added to M src/ref/rrefsqljmerge.dita Hope it's okay. Thanks.
          Hide
          Rick Hillegas added a comment -

          Looks good to me, Kim. +1 Thanks.

          Show
          Rick Hillegas added a comment - Looks good to me, Kim. +1 Thanks.
          Hide
          ASF subversion and git services added a comment -

          Commit 1601410 from Kim Haase in branch 'docs/trunk'
          [ https://svn.apache.org/r1601410 ]

          DERBY-6526 Document the MERGE statement

          Modified a Reference Manual topic to add upgrade information.

          Patches: DERBY-6526-upgrade.diff

          Show
          ASF subversion and git services added a comment - Commit 1601410 from Kim Haase in branch 'docs/trunk' [ https://svn.apache.org/r1601410 ] DERBY-6526 Document the MERGE statement Modified a Reference Manual topic to add upgrade information. Patches: DERBY-6526 -upgrade.diff
          Hide
          Kim Haase added a comment -

          And again thank you, Rick.

          Committed patch DERBY-6526-upgrade.diff to documentation trunk at revision 1601410.

          Show
          Kim Haase added a comment - And again thank you, Rick. Committed patch DERBY-6526 -upgrade.diff to documentation trunk at revision 1601410.

            People

            • Assignee:
              Kim Haase
              Reporter:
              Rick Hillegas
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development