There are many unused methods in BrokeredCallableStatement. This issue adds test for them.
Improve code coverage of org.apache.derby.iapi.jdbc.BrokeredCallableStatement
Invoke logical statements with existing statement tests
It looks like most of the new code is based on the code in CallableTest. Could we achieve similar coverage, with less code, by making CallableTest.suite() use TestConfiguration.connectionXADecorator() to run CallableTest in an XA environment?
Thanks Knut. Initially I wasn't very much sure about it. Seems to work.
Thanks, Siddharth. The latest patch had a conflict with DERBY-5871, which handled the corresponding issue on the client. I resolved the conflict manually and committed the patch to trunk with revision 1372848.
The test failed on weme6.2 with following stack trace. The test ran with revision 1373684 and this is on a Windows/VMWare machine
1) CallableTest:brokeredjunit.framework.AssertionFailedError: java.lang.NullPointerException
I suppose we should make the XA and connection pool decorators skip the test on platforms where we don't have implementations of XADataSource and ConnectionPoolDataSource. The attached patch (disable.diff) does that.
Committed revision 1374215.
[bulk update] Close all resolved issues that haven't been updated for more than one year.