Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.10.1.1
    • Fix Version/s: 10.10.1.1
    • Component/s: Test
    • Labels:
      None

      Description

      There are many unused methods in BrokeredCallableStatement. This issue adds test for them.

      1. derbyBrokeredCallable.patch
        14 kB
        Siddharth Srivastava
      2. derbycallabledecorator
        1 kB
        Siddharth Srivastava
      3. disable.diff
        2 kB
        Knut Anders Hatlen

        Issue Links

          Activity

          Hide
          Knut Anders Hatlen added a comment -

          It looks like most of the new code is based on the code in CallableTest. Could we achieve similar coverage, with less code, by making CallableTest.suite() use TestConfiguration.connectionXADecorator() to run CallableTest in an XA environment?

          Show
          Knut Anders Hatlen added a comment - It looks like most of the new code is based on the code in CallableTest. Could we achieve similar coverage, with less code, by making CallableTest.suite() use TestConfiguration.connectionXADecorator() to run CallableTest in an XA environment?
          Hide
          Siddharth Srivastava added a comment -

          Thanks Knut. Initially I wasn't very much sure about it. Seems to work.

          Show
          Siddharth Srivastava added a comment - Thanks Knut. Initially I wasn't very much sure about it. Seems to work.
          Hide
          Knut Anders Hatlen added a comment -

          Thanks, Siddharth. The latest patch had a conflict with DERBY-5871, which handled the corresponding issue on the client. I resolved the conflict manually and committed the patch to trunk with revision 1372848.

          Show
          Knut Anders Hatlen added a comment - Thanks, Siddharth. The latest patch had a conflict with DERBY-5871 , which handled the corresponding issue on the client. I resolved the conflict manually and committed the patch to trunk with revision 1372848.
          Hide
          Mamta A. Satoor added a comment -

          The test failed on weme6.2 with following stack trace. The test ran with revision 1373684 and this is on a Windows/VMWare machine
          1) CallableTest:brokeredjunit.framework.AssertionFailedError: java.lang.NullPointerException
          at org.apache.derbyTesting.junit.JDBCDataSource.getDataSourceObject(JDBCDataSource.java:182)
          at org.apache.derbyTesting.junit.J2EEDataSource.getXADataSource(J2EEDataSource.java:98)
          at org.apache.derbyTesting.junit.XADataSourceConnector.setConfiguration(XADataSourceConnector.java:51)
          at org.apache.derbyTesting.junit.ConnectorSetup.getNewConfiguration(ConnectorSetup.java:49)
          at org.apache.derbyTesting.junit.ChangeConfigurationSetup.setUp(ChangeConfigurationSetup.java:37)
          at junit.extensions.TestSetup$1.protect(TestSetup.java:20)
          at junit.extensions.TestSetup.run(TestSetup.java:25)

          Show
          Mamta A. Satoor added a comment - The test failed on weme6.2 with following stack trace. The test ran with revision 1373684 and this is on a Windows/VMWare machine 1) CallableTest:brokeredjunit.framework.AssertionFailedError: java.lang.NullPointerException at org.apache.derbyTesting.junit.JDBCDataSource.getDataSourceObject(JDBCDataSource.java:182) at org.apache.derbyTesting.junit.J2EEDataSource.getXADataSource(J2EEDataSource.java:98) at org.apache.derbyTesting.junit.XADataSourceConnector.setConfiguration(XADataSourceConnector.java:51) at org.apache.derbyTesting.junit.ConnectorSetup.getNewConfiguration(ConnectorSetup.java:49) at org.apache.derbyTesting.junit.ChangeConfigurationSetup.setUp(ChangeConfigurationSetup.java:37) at junit.extensions.TestSetup$1.protect(TestSetup.java:20) at junit.extensions.TestSetup.run(TestSetup.java:25)
          Hide
          Knut Anders Hatlen added a comment -

          I suppose we should make the XA and connection pool decorators skip the test on platforms where we don't have implementations of XADataSource and ConnectionPoolDataSource. The attached patch (disable.diff) does that.

          Show
          Knut Anders Hatlen added a comment - I suppose we should make the XA and connection pool decorators skip the test on platforms where we don't have implementations of XADataSource and ConnectionPoolDataSource. The attached patch (disable.diff) does that.
          Hide
          Knut Anders Hatlen added a comment -

          Committed revision 1374215.

          Show
          Knut Anders Hatlen added a comment - Committed revision 1374215.
          Hide
          Knut Anders Hatlen added a comment -

          [bulk update] Close all resolved issues that haven't been updated for more than one year.

          Show
          Knut Anders Hatlen added a comment - [bulk update] Close all resolved issues that haven't been updated for more than one year.

            People

            • Assignee:
              Siddharth Srivastava
              Reporter:
              Siddharth Srivastava
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development