Derby
  1. Derby
  2. DERBY-5871

Invoke logical statements with existing statement tests

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.10.1.1
    • Component/s: Test
    • Labels:
      None

      Description

      Code coverage of logical statements can be improved by invoking them in existing statement tests. This could be done by having a decorator that makes use of pooled connections.

      1. derby-5871-CallblStmtTst.patch
        0.8 kB
        Mohamed Nufail
      2. derby-5871-CallblTst.patch
        0.8 kB
        Mohamed Nufail
      3. derby-5871-PrepStmtTst.patch
        2 kB
        Mohamed Nufail

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          8h 56m 1 Bryan Pendleton 21/Jul/12 18:44
          Resolved Resolved Closed Closed
          481d 14h 31m 1 Knut Anders Hatlen 15/Nov/13 08:15
          Myrna van Lunteren made changes -
          Component/s Test [ 11413 ]
          Knut Anders Hatlen made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Knut Anders Hatlen added a comment -

          [bulk update: close all resolved issues that haven't had any activity the last year]

          Show
          Knut Anders Hatlen added a comment - [bulk update: close all resolved issues that haven't had any activity the last year]
          Gavin made changes -
          Workflow jira [ 12717517 ] Default workflow, editable Closed status [ 12801754 ]
          Knut Anders Hatlen made changes -
          Link This issue is related to DERBY-5854 [ DERBY-5854 ]
          Bryan Pendleton made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 10.10.0.0 [ 12321550 ]
          Resolution Fixed [ 1 ]
          Hide
          Bryan Pendleton added a comment -

          I believe that all the work on this issue is complete. Marking resolved by revision 1364068.

          Show
          Bryan Pendleton added a comment - I believe that all the work on this issue is complete. Marking resolved by revision 1364068.
          Hide
          Knut Anders Hatlen added a comment -

          Thanks, Nufail. I actually need CallableStatementTest to run on logical statements to test the fix I'm working on for DERBY-5872. Great timing!

          The patches look good to me, and I've verified that the tests still pass. These tests don't take long to run, so running them in one more configuration doesn't add much to the total time of suites.All, and the extra testing seems worthwhile.

          Committed revision 1364068.

          Show
          Knut Anders Hatlen added a comment - Thanks, Nufail. I actually need CallableStatementTest to run on logical statements to test the fix I'm working on for DERBY-5872 . Great timing! The patches look good to me, and I've verified that the tests still pass. These tests don't take long to run, so running them in one more configuration doesn't add much to the total time of suites.All, and the extra testing seems worthwhile. Committed revision 1364068.
          Mohamed Nufail made changes -
          Field Original Value New Value
          Attachment derby-5871-CallblStmtTst.patch [ 12537443 ]
          Attachment derby-5871-CallblTst.patch [ 12537444 ]
          Attachment derby-5871-PrepStmtTst.patch [ 12537445 ]
          Hide
          Mohamed Nufail added a comment -

          Attached,
          derby-5871-PrepdStmtTst.patch
          derby-5871-CallblStmtTst.patch
          derby-5871-CallblTst.patch

          These patches add a connectionCPDecorator to the following tests,

          • org.apache.derbyTesting.functionTests.tests.derbynet.PrepareStatementTest
          • org.apache.derbyTesting.functionTests.tests.jdbc4.CallableStatementTest
          • org.apache.derbyTesting.functionTests.tests.jdbcapi.CallableTest
          Show
          Mohamed Nufail added a comment - Attached, derby-5871-PrepdStmtTst.patch derby-5871-CallblStmtTst.patch derby-5871-CallblTst.patch These patches add a connectionCPDecorator to the following tests, org.apache.derbyTesting.functionTests.tests.derbynet.PrepareStatementTest org.apache.derbyTesting.functionTests.tests.jdbc4.CallableStatementTest org.apache.derbyTesting.functionTests.tests.jdbcapi.CallableTest
          Mohamed Nufail created issue -

            People

            • Assignee:
              Mohamed Nufail
              Reporter:
              Mohamed Nufail
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development