[DERBY-5847] Clean up IDE warnings in DRDAConnThread

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 10.10.1.1
• Fix Version/s: 10.10.1.1
• Component/s: Network Server
• Assignee: Knut Anders Hatlen
• Reporter: Knut Anders Hatlen
• Created: 04/Jul/12 17:06
• Updated: 24/Jul/12 17:31
• Resolved: 20/Jul/12 06:14

Description

When I open DRDAConnThread in NetBeans, I see 49 warnings. Most of them are harmless (like static fields accessed via an instance, suggestions about using StringBuilder instead of StringBuffer, or using System.arraycopy() instead of for loops). Others indicate real problems, like the use of != to compare SQL states in writeSQLDIAGGRP().

We should clean up the warnings so that it's easier to notice new warnings about potential problems.

Issue Links

• is related to: DERBY-436 clean up imports and static field references in DRDA classes