Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5847

Clean up IDE warnings in DRDAConnThread

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.10.1.1
    • Fix Version/s: 10.10.1.1
    • Component/s: Network Server
    • Labels:
      None

      Description

      When I open DRDAConnThread in NetBeans, I see 49 warnings. Most of them are harmless (like static fields accessed via an instance, suggestions about using StringBuilder instead of StringBuffer, or using System.arraycopy() instead of for loops). Others indicate real problems, like the use of != to compare SQL states in writeSQLDIAGGRP().

      We should clean up the warnings so that it's easier to notice new warnings about potential problems.

        Attachments

        1. d5847-1a-string-equality.patch
          2 kB
          Knut Anders Hatlen
        2. d5847-2a-unnecessary-return.patch
          2 kB
          Knut Anders Hatlen
        3. d5847-3a-static-fields-and-imports.patch
          11 kB
          Knut Anders Hatlen
        4. d5847-4a-unused-assignment.patch
          8 kB
          Knut Anders Hatlen
        5. d5847-5a-performance-warnings.patch
          5 kB
          Knut Anders Hatlen
        6. d5847-6a-obsolete-collection.patch
          2 kB
          Knut Anders Hatlen
        7. d5847-7a-sync-on-non-final.patch
          3 kB
          Knut Anders Hatlen
        8. d5847-8a-misc.patch
          3 kB
          Knut Anders Hatlen
        9. d5847-9a-this-leak.patch
          5 kB
          Knut Anders Hatlen
        10. d5847-9b-this-leak.patch
          5 kB
          Knut Anders Hatlen
        11. d5847-8b-misc.patch
          2 kB
          Knut Anders Hatlen
        12. d5847-10a-overrides-and-braces.patch
          107 kB
          Knut Anders Hatlen

          Issue Links

            Activity

              People

              • Assignee:
                knutanders Knut Anders Hatlen
                Reporter:
                knutanders Knut Anders Hatlen
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: