Derby
  1. Derby
  2. DERBY-5664

Include driver tests in jdbcapi suite

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 10.9.1.0
    • Fix Version/s: 10.9.1.0
    • Component/s: Test
    • Labels:
      None

      Description

      The tests AutoloadTest, JDBCDriversEmbeddedTest, JDBCDriversClientTest and JDBCDriversAllTest are in the junit-all ant target but not in suites.All. We should make them part of the jdbcapi suite so that they are picked up by suites.All too.

      1. d5664-1a-jdbcapi-suite.diff
        4 kB
        Knut Anders Hatlen
      2. d5664-1b-shutdown.diff
        5 kB
        Knut Anders Hatlen
      3. d5664-2a-junit-core.diff
        1 kB
        Knut Anders Hatlen

        Issue Links

          Activity

          Knut Anders Hatlen created issue -
          Knut Anders Hatlen made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Knut Anders Hatlen added a comment -

          Attaching a patch that adds the above mentioned tests to the jdbcapi suite. The tests must be run in separate JVMs in order to test that the drivers are auto-loaded on startup, and the patch handles this by spawning processes for each of the tests.

          Show
          Knut Anders Hatlen added a comment - Attaching a patch that adds the above mentioned tests to the jdbcapi suite. The tests must be run in separate JVMs in order to test that the drivers are auto-loaded on startup, and the patch handles this by spawning processes for each of the tests.
          Knut Anders Hatlen made changes -
          Attachment d5664-1a-jdbcapi-suite.diff [ 12519060 ]
          Hide
          Knut Anders Hatlen added a comment -

          The 1a patch was only tested with a small part of jdbcapi, and when running the full suite some problems showed up. The spawned test processes access the default test database, which is already booted in the main test process, and the spawned processes failed because attempts to double-boot the database were detected.

          Attaching an updated patch that adds a decorator that shuts down the database engine in the main test process before spawning new test processes. With this change, suites.All ran successfully in my environment.

          Show
          Knut Anders Hatlen added a comment - The 1a patch was only tested with a small part of jdbcapi, and when running the full suite some problems showed up. The spawned test processes access the default test database, which is already booted in the main test process, and the spawned processes failed because attempts to double-boot the database were detected. Attaching an updated patch that adds a decorator that shuts down the database engine in the main test process before spawning new test processes. With this change, suites.All ran successfully in my environment.
          Knut Anders Hatlen made changes -
          Attachment d5664-1b-shutdown.diff [ 12519317 ]
          Hide
          Knut Anders Hatlen added a comment -

          Committed revision 1303693.

          Show
          Knut Anders Hatlen added a comment - Committed revision 1303693.
          Knut Anders Hatlen made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Fix Version/s 10.9.0.0 [ 12316344 ]
          Resolution Fixed [ 1 ]
          Mike Matrigali made changes -
          Link This issue relates to DERBY-5670 [ DERBY-5670 ]
          Hide
          Mike Matrigali added a comment -

          It looks like this change is not working at least so far on ibm16, linux. see DERBY-5670

          Show
          Mike Matrigali added a comment - It looks like this change is not working at least so far on ibm16, linux. see DERBY-5670
          Hide
          Knut Anders Hatlen added a comment -

          Reopening as the junit-all target in build.xml now runs the different variants of AutoloadTest twice (first explicitly, and then implicitly via the jdbcapi suite). It suffices to run them once.

          Show
          Knut Anders Hatlen added a comment - Reopening as the junit-all target in build.xml now runs the different variants of AutoloadTest twice (first explicitly, and then implicitly via the jdbcapi suite). It suffices to run them once.
          Knut Anders Hatlen made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Knut Anders Hatlen made changes -
          Status Reopened [ 4 ] In Progress [ 3 ]
          Hide
          Knut Anders Hatlen added a comment -

          Attaching d5664-2a-junit-core.diff which removes AutoloadTest, JDBCDriversEmbeddedTest, JDBCDriversClientTest and JDBCDriversAllTest from the junit-core target.

          I ran junit-all (which includes junit-core) successfully and verified that the four tests did no longer appear in their own top-level report files, but instead appeared in the report from the jdbcapi suite.

          Show
          Knut Anders Hatlen added a comment - Attaching d5664-2a-junit-core.diff which removes AutoloadTest, JDBCDriversEmbeddedTest, JDBCDriversClientTest and JDBCDriversAllTest from the junit-core target. I ran junit-all (which includes junit-core) successfully and verified that the four tests did no longer appear in their own top-level report files, but instead appeared in the report from the jdbcapi suite.
          Knut Anders Hatlen made changes -
          Attachment d5664-2a-junit-core.diff [ 12520123 ]
          Knut Anders Hatlen made changes -
          Issue & fix info Patch Available [ 10102 ]
          Hide
          Knut Anders Hatlen added a comment -

          Committed revision 1306452.

          Show
          Knut Anders Hatlen added a comment - Committed revision 1306452.
          Knut Anders Hatlen made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Issue & fix info Patch Available [ 10102 ]
          Resolution Fixed [ 1 ]
          Knut Anders Hatlen made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Mike Matrigali made changes -
          Link This issue relates DERBY-6178 [ DERBY-6178 ]
          Gavin made changes -
          Link This issue relates to DERBY-6178 [ DERBY-6178 ]
          Gavin made changes -
          Link This issue relates to DERBY-6178 [ DERBY-6178 ]
          Gavin made changes -
          Workflow jira [ 12658521 ] Default workflow, editable Closed status [ 12796868 ]

            People

            • Assignee:
              Knut Anders Hatlen
              Reporter:
              Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development