Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-5480

File handle leak in MessageVetter

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 10.9.1.0
    • 10.8.3.3, 10.9.1.0
    • Build tools
    • None

    Description

      MessageVetter, which is executed by the build script, contains the following code to load a message file:

      properties.load(new FileInputStream(file));

      The FileInputStream isn't closed. Since MessageVetter runs embedded in the Ant process, file handles may be held open and cause problems later in the build. MessageVetter goes through more than 800 files, so the number of open file handles may be high when it has completed.

      Even though FileInputStream has a finalize() method that calls close(), so the streams will be closed eventually, we should close the streams explicitly to release system resources as early as possible.

      Attachments

        1. d5480-1a.diff
          0.8 kB
          Knut Anders Hatlen

        Issue Links

          Activity

            People

              knutanders Knut Anders Hatlen
              knutanders Knut Anders Hatlen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: