[DERBY-5480] File handle leak in MessageVetter

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 10.9.1.0
• Fix Version/s: 10.8.3.3, 10.9.1.0
• Component/s: Build tools
• Assignee: Knut Anders Hatlen
• Reporter: Knut Anders Hatlen
• Created: 25/Oct/11 12:24
• Updated: 23/Jul/13 01:58
• Resolved: 26/Oct/11 07:59

Description

MessageVetter, which is executed by the build script, contains the following code to load a message file:

properties.load(new FileInputStream(file));

The FileInputStream isn't closed. Since MessageVetter runs embedded in the Ant process, file handles may be held open and cause problems later in the build. MessageVetter goes through more than 800 files, so the number of open file handles may be high when it has completed.

Even though FileInputStream has a finalize() method that calls close(), so the streams will be closed eventually, we should close the streams explicitly to release system resources as early as possible.

Issue Links

• is related to: DERBY-6289 Derby 10.8 backport issue (summer 2013)