[DERBY-5465] Broken null checks in NsTest

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 10.8.2.2
• Fix Version/s: 10.8.3.0, 10.9.1.0
• Component/s: Test
• Assignee: Knut Anders Hatlen
• Reporter: Knut Anders Hatlen
• Created: 15/Oct/11 16:09
• Updated: 01/Nov/12 21:10
• Resolved: 15/Oct/11 17:02

Description

NsTest contains more occurrences of the broken null checking pattern found in DERBY-5452.

Initializer.java:

if (e.getMessage().equals(null))

{ e.printStackTrace(System.out); }

DbSetup.java:

if (e.getMessage().equals(null))

{ System.out.println("NULL error message detected"); System.out.println("Here is the NULL exection - " + e.toString()); System.out.println("Stack trace of the NULL exception - "); e.printStackTrace(System.out); }

DbUtil.java:

if (e.getMessage().equals(null))

{ System.out.println(getThreadName() + " dbUtil --> NULL error message detected"); System.out .println(getThreadName() + " dbUtil --> Here is the NULL exection - " + e.toString()); System.out.println(getThreadName() + " dbUtil --> Stack trace of the NULL exception - "); e.printStackTrace(System.out); }

If getMessage() returns null, the null checks will throw a NullPointerException instead of evaluating to true.

Issue Links

• relates to: DERBY-5452 Possible NPE in NsTest.printException()