Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.8.2.2
    • Fix Version/s: 10.8.3.0, 10.9.1.0
    • Component/s: Test
    • Labels:
      None

      Description

      NsTest contains more occurrences of the broken null checking pattern found in DERBY-5452.

      Initializer.java:

      if (e.getMessage().equals(null))

      { e.printStackTrace(System.out); }

      DbSetup.java:

      if (e.getMessage().equals(null))

      { System.out.println("NULL error message detected"); System.out.println("Here is the NULL exection - " + e.toString()); System.out.println("Stack trace of the NULL exception - "); e.printStackTrace(System.out); }

      DbUtil.java:

      if (e.getMessage().equals(null))

      { System.out.println(getThreadName() + " dbUtil --> NULL error message detected"); System.out .println(getThreadName() + " dbUtil --> Here is the NULL exection - " + e.toString()); System.out.println(getThreadName() + " dbUtil --> Stack trace of the NULL exception - "); e.printStackTrace(System.out); }

      If getMessage() returns null, the null checks will throw a NullPointerException instead of evaluating to true.

        Attachments

        1. null.diff
          2 kB
          Knut Anders Hatlen

          Issue Links

            Activity

              People

              • Assignee:
                knutanders Knut Anders Hatlen
                Reporter:
                knutanders Knut Anders Hatlen
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: