[DERBY-5452] Possible NPE in NsTest.printException()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 10.8.1.2, 10.9.1.0
• Fix Version/s: 10.8.2.2, 10.9.1.0
• Component/s: Test
• Assignee: Knut Anders Hatlen
• Reporter: Knut Anders Hatlen
• Created: 10/Oct/11 09:08
• Updated: 15/Oct/11 16:11
• Resolved: 10/Oct/11 11:07

Description

NsTest.printException() contains the following piece of code:

if (e.getMessage().equals(null))

{ System.out.println("NULL error message detected"); System.out.println("Here is the NULL exection - " + e.toString()); System.out.println("Stack trace of the NULL exception - "); e.printStackTrace(System.out); }

It's supposed to detect if e.getMessage() returns null. However, if it does return null, calling equals() on the return value will result in a NullPointerException.

The condition should be changed to (e.getMessage() == null).

Issue Links

• is related to: DERBY-5465 Broken null checks in NsTest