Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10.9.1.0
    • Component/s: Test
    • Labels:
    1. 5332-1.patch
      5 kB
      Houx Zhang
    2. 5332-1.stat
      0.4 kB
      Houx Zhang

      Issue Links

        Activity

        Hide
        Houx Zhang added a comment -

        In 5332-1.patch, ij3Test.java has been created to do this converting.

        It just adopts 3 properties:

        props.setProperty("ij.database", "jdbc:derby:wombat;create=true");
        props.setProperty("ij.showNoConnectionsAtStart", "true");
        props.setProperty("ij.showNoCountForSelect", "true");

        as ij.dataSource is not set in ij3_app.properties, the two properties below has been removed in the patch.
        -ij.dataSource.databaseName=wombat
        -ij.dataSource.createDatabase=create

        Besides, ij3.out is been changed as below.

        Index: java/testing/org/apache/derbyTesting/functionTests/master/ij3.out
        ===================================================================
        — java/testing/org/apache/derbyTesting/functionTests/master/ij3.out (revision 1146645)
        +++ java/testing/org/apache/derbyTesting/functionTests/master/ij3.out (working copy)
        @@ -1,4 +1,4 @@
        -ij> –
        +ij(CONNECTION1)> –
        – Licensed to the Apache Software Foundation (ASF) under one or more
        – contributor license agreements. See the NOTICE file distributed with
        – this work for additional information regarding copyright ownership.
        @@ -16,9 +16,10 @@

        – this test shows that ij can detect the driver from the URL.
        – the ij.properties file sets ij.database and nothing else.
        +
        values 'PASS';
        1


        PASS
        -ij> – this test also exercises the shutdown on exit code
        +ij(CONNECTION1)> – this test also exercises the shutdown on exit code
        exit;

        With the property ij.database=jdbc:derby:wombat;create=true, and the default connection for ScriptTestCase, there are two conenections, so the out is different.

        Show
        Houx Zhang added a comment - In 5332-1.patch, ij3Test.java has been created to do this converting. It just adopts 3 properties: props.setProperty("ij.database", "jdbc:derby:wombat;create=true"); props.setProperty("ij.showNoConnectionsAtStart", "true"); props.setProperty("ij.showNoCountForSelect", "true"); as ij.dataSource is not set in ij3_app.properties, the two properties below has been removed in the patch. -ij.dataSource.databaseName=wombat -ij.dataSource.createDatabase=create Besides, ij3.out is been changed as below. Index: java/testing/org/apache/derbyTesting/functionTests/master/ij3.out =================================================================== — java/testing/org/apache/derbyTesting/functionTests/master/ij3.out (revision 1146645) +++ java/testing/org/apache/derbyTesting/functionTests/master/ij3.out (working copy) @@ -1,4 +1,4 @@ -ij> – +ij(CONNECTION1)> – – Licensed to the Apache Software Foundation (ASF) under one or more – contributor license agreements. See the NOTICE file distributed with – this work for additional information regarding copyright ownership. @@ -16,9 +16,10 @@ – – this test shows that ij can detect the driver from the URL. – the ij.properties file sets ij.database and nothing else. + values 'PASS'; 1 PASS -ij> – this test also exercises the shutdown on exit code +ij(CONNECTION1)> – this test also exercises the shutdown on exit code exit; With the property ij.database=jdbc:derby:wombat;create=true, and the default connection for ScriptTestCase, there are two conenections, so the out is different.
        Hide
        Bryan Pendleton added a comment -

        The patch builds and runs cleanly in my environment.

        Committed to the repository trunk as revision 1148590.

        Thank you for the contribution!

        Show
        Bryan Pendleton added a comment - The patch builds and runs cleanly in my environment. Committed to the repository trunk as revision 1148590. Thank you for the contribution!
        Hide
        Houx Zhang added a comment -

        Thanks for your checking, Bryan.

        Show
        Houx Zhang added a comment - Thanks for your checking, Bryan.

          People

          • Assignee:
            Houx Zhang
            Reporter:
            Houx Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development