[DERBY-5331] Incorrect use of CharsetEncoder in DDMWriter

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 10.4.1.3, 10.4.2.0, 10.5.1.1, 10.5.2.0, 10.5.3.0, 10.6.1.0, 10.6.2.1, 10.7.1.1, 10.8.1.2
• Fix Version/s: 10.8.2.2, 10.9.1.0
• Component/s: Network Server
• Assignee: Knut Anders Hatlen
• Reporter: Knut Anders Hatlen
• Created: 14/Jul/11 09:05
• Updated: 24/Jul/12 17:26
• Resolved: 20/Jul/11 09:36

Description

DDMWriter has two calls to CharsetEncoder.encode(), in writeLDString() and writeString(). According to the javadoc for CharsetEncoder, one should call reset() before one calls encode(), and flush() after on. DDMWriter doesn't call reset() or flush(). I'm not aware of any problems that happen because of it, but we should follow the spec to avoid surprises.

Issue Links

• relates to: DERBY-2936 Use java.nio.ByteBuffer for buffering in DDMWriter