[DERBY-2936] Use java.nio.ByteBuffer for buffering in DDMWriter

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 10.4.1.3
• Component/s: Network Server
• Assignee: Knut Anders Hatlen
• Reporter: Knut Anders Hatlen
• Created: 13/Jul/07 12:25
• Updated: 14/Jul/11 09:09
• Resolved: 25/Aug/07 12:56

Description

org.apache.derby.impl.drda.DDMWriter uses a byte array as a buffer. Wrapping the array in a java.nio.ByteBuffer has some advantages, for instance:

• utility methods for encoding primitive types into the byte array could be used instead of manually encoding the values
• it allows us to encode strings directly into the buffer (using a CharsetEncoder) without doing an expensive String.getBytes(String encoding) in an intermediate step

By using a utility class, the code becomes easier to maintain. Also, ByteBuffer allows us to access the backing byte array without going through the ByteBuffer interface, so we still have the possibility to modify the byte array directly in cases where that's more convenient.

Issue Links

• is related to: DERBY-5331 Incorrect use of CharsetEncoder in DDMWriter
• is related to: DERBY-5210 Use java.nio.ByteBuffer in client.net.Request