Derby
  1. Derby
  2. DERBY-5089

Improve tracing/logging of runtime exceptions raised in the istat thread

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.8.1.2
    • Fix Version/s: 10.8.1.2
    • Component/s: Services, Store
    • Labels:
      None

      Description

      For the sake of observability and debugging in the wild, the tracing and/or logging of runtime exceptions raised in the istat thread should be improved.

        Issue Links

          Activity

          Kristian Waagan created issue -
          Hide
          Kristian Waagan added a comment -

          Attached patch 1a, which adds tracing of runtime exceptions. It also adds logging of checked exceptions in some cases.

          Committed to trunk with revision 1078449.

          The best way to read the information emitted by the istat thread is to enable both logging and tracing, and then grepping for "istat" in the derby.log.

          I except that logging/tracing needs another iteration of work after 10.8.1, i.e. what information to log, what to trace etc. The logging may still be a bit too chatty, and one possible solution is to use more than one level of logging (i.e. log only the fact that a table has had all associated index statistics updated on the lowest level).
          Another solution is to introduce log categories, i.e. SCHEDULE, STATS, SCAN_DURATIONS, but currently I'm more in favor of reducing the overall volume and keeping this simple.

          We can discuss this further if/when the need for better observability, and configuration, arises.

          Show
          Kristian Waagan added a comment - Attached patch 1a, which adds tracing of runtime exceptions. It also adds logging of checked exceptions in some cases. Committed to trunk with revision 1078449. The best way to read the information emitted by the istat thread is to enable both logging and tracing, and then grepping for "istat" in the derby.log. I except that logging/tracing needs another iteration of work after 10.8.1, i.e. what information to log, what to trace etc. The logging may still be a bit too chatty, and one possible solution is to use more than one level of logging (i.e. log only the fact that a table has had all associated index statistics updated on the lowest level). Another solution is to introduce log categories, i.e. SCHEDULE, STATS, SCAN_DURATIONS, but currently I'm more in favor of reducing the overall volume and keeping this simple. We can discuss this further if/when the need for better observability, and configuration, arises.
          Kristian Waagan made changes -
          Field Original Value New Value
          Attachment derby-5089-1a-improved_tracing.diff [ 12472778 ]
          Hide
          Kristian Waagan added a comment -

          Marking issue as resolved.

          Show
          Kristian Waagan added a comment - Marking issue as resolved.
          Kristian Waagan made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 10.8.0.0 [ 12315561 ]
          Resolution Fixed [ 1 ]
          Kristian Waagan made changes -
          Link This issue relates to DERBY-4939 [ DERBY-4939 ]
          Knut Anders Hatlen made changes -
          Link This issue is related to DERBY-5124 [ DERBY-5124 ]
          Rick Hillegas made changes -
          Affects Version/s 10.8.1.1 [ 12316356 ]
          Affects Version/s 10.8.1.0 [ 12315561 ]
          Fix Version/s 10.8.1.1 [ 12316356 ]
          Fix Version/s 10.8.1.0 [ 12315561 ]
          Rick Hillegas made changes -
          Affects Version/s 10.8.1.2 [ 12316362 ]
          Affects Version/s 10.8.1.1 [ 12316356 ]
          Fix Version/s 10.8.1.2 [ 12316362 ]
          Fix Version/s 10.8.1.1 [ 12316356 ]
          Hide
          Knut Anders Hatlen added a comment -

          [bulk update] Close all resolved issues that haven't been updated for more than one year.

          Show
          Knut Anders Hatlen added a comment - [bulk update] Close all resolved issues that haven't been updated for more than one year.
          Knut Anders Hatlen made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Workflow jira [ 12600520 ] Default workflow, editable Closed status [ 12801915 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          3d 13h 6m 1 Kristian Waagan 06/Mar/11 11:28
          Resolved Resolved Closed Closed
          833d 21h 50m 1 Knut Anders Hatlen 17/Jun/13 09:19

            People

            • Assignee:
              Kristian Waagan
              Reporter:
              Kristian Waagan
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved:

                Development