Derby
  1. Derby
  2. DERBY-4893

Allow Java 5 language constructs in build code

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 10.7.1.1
    • Fix Version/s: 10.7.1.1
    • Component/s: Build tools
    • Labels:
      None

      Description

      We already allow the use of methods and classes that only exist in Java 5 and higher in code that only runs at build time, but java/build/org/apache/derbyBuild/build.xml specifies source and target level "1.4", so we cannot use the new syntax introduced in Java 5. I think we should also change source and target level to allow the new (well, not so new anymore...) language constructs.

      (I noticed this when I started writing code to perform sanity checking of the message files at build time (DERBY-4796) and couldn't use the simpler for loop syntax.)

      1. build-java5.diff
        24 kB
        Knut Anders Hatlen

        Issue Links

          Activity

          Hide
          Knut Anders Hatlen added a comment -

          Committed revision 1032479.

          Show
          Knut Anders Hatlen added a comment - Committed revision 1032479.
          Hide
          Knut Anders Hatlen added a comment -

          The attached patch changes source and target level to 1.5 in java/build/org/apache/derbyBuild/build.xml. This made the compiler emit some "unchecked" warnings, so the patch also changes some variable declarations in the build code to silence the warnings.

          All the regression tests ran cleanly with the patch.

          Show
          Knut Anders Hatlen added a comment - The attached patch changes source and target level to 1.5 in java/build/org/apache/derbyBuild/build.xml. This made the compiler emit some "unchecked" warnings, so the patch also changes some variable declarations in the build code to silence the warnings. All the regression tests ran cleanly with the patch.

            People

            • Assignee:
              Knut Anders Hatlen
              Reporter:
              Knut Anders Hatlen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development