Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-4520

Refactor and extend data type cloning facilities



    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • Store
    • None


      With the increased use of streams to represent data values, the cloning facilities needs to be improved.

      Unless I get pushback, I will proceed by producing patches to reach the following goals:

      • move the functionality provided by CloneableObject into DataValueDescriptor
        (all classes implementing CloneableObject also implements DataValueDescriptor)
      • introduce the cloning methods cloneValue, cloneState and cloneHolder (all in DataValueDescriptor, see description below)
        Note that they all return a usable DVD. I'm all ears for better names for the clone methods (another suggestion mentioned is cloneDeep, cloneHalfDeep, and cloneShallow).

      NOTE: See comment below, the method names changed during the course of development.

      cloneValue <deep> (new method, functionality was present through combined calls to the DVD public interface)

      • a DVD obtained through cloneValue is independent of other DVDs and the state of the Derby store
      • the data value will be materialized

      cloneState <halfDeep> (~= DataValueDescriptor.getClone)

      • a DVD obtained through cloneState is independent of other DVDs, but may depend on the state of the Derby store (due to references to store streams)
      • the data value will be materialized if the value is represented by a non-cloneable stream or if Derby believes materializing the value is more appropriate than keeping the stream representation

      cloneHolder <shallow> (~= CloneableObject.cloneObject)

      • a DVD obtained through cloneHolder is dependent on the original DVD and its clones made through cloneHolder. If one of the DVDs changes its state, all of them will be affected. Will also be dependent on the state of the Derby store if there are references to store streams.
      • the data value will never be materialized due to cloneHolder being invoked

      For many of the data types, cloneState and cloneHolder will forward to cloneValue.

      cloneState will be used the most. cloneValue is currently only required in the sorter. cloneHolder is required (for performance reasons and maybe to avoid OOME) when DVDs pass through temporary holders (BackingStoreHashtable, TemporaryRowHolderImpl). I have not gone through all the usages of cloneState to see if any of them can be, or has to be, replaced with another clone-call.

      The ability to clone store streams will be added by Mike's patch attached to DERBY-3650.

      • New method names:
        It turned out that using only two methods was sufficient:
        cloneHolder <shallow> (as above)

      cloneValue(boolean forceMaterialization) <halfDeep or deep>
      Basically, cloneValue(false) equals cloneState() above, and cloneValue(true) equals cloneValue() above.


        1. derby-4520-7b-lob_clonevalue_methods.diff
          8 kB
          Kristian Waagan
        2. derby-4520-7a-lob_clonevalue_methods.diff
          8 kB
          Kristian Waagan
        3. derby-4520-6a-unused_imports.diff
          7 kB
          Kristian Waagan
        4. derby-4520-5a-getClone_renamed_cloneValue.stat
          3 kB
          Kristian Waagan
        5. derby-4520-5a-getClone_renamed_cloneValue.diff
          44 kB
          Kristian Waagan
        6. derby-4520-4a-cloneObject_renamed_cloneHolder.diff
          7 kB
          Kristian Waagan
        7. derby-4520-3b-CloneableStream_and_delayed_fill.diff
          9 kB
          Kristian Waagan
        8. derby-4520-3b-CloneableStream_and_delayed_fill.stat
          0.4 kB
          Kristian Waagan
        9. derby-4520-3a-CloneableStream_and_delayed_fill.stat
          0.4 kB
          Kristian Waagan
        10. derby-4520-3a-CloneableStream_and_delayed_fill.diff
          8 kB
          Kristian Waagan
        11. derby-4520-2a-remove_CloneableObject_iface.stat
          0.7 kB
          Kristian Waagan
        12. derby-4520-2a-remove_CloneableObject_iface.diff
          13 kB
          Kristian Waagan
        13. derby-4520-1a-RowLocation_cloning.diff
          6 kB
          Kristian Waagan
        14. derby-4520-1a-RowLocation_cloning.diff
          4 kB
          Kristian Waagan

        Issue Links



              kristwaa Kristian Waagan
              kristwaa Kristian Waagan
              0 Vote for this issue
              0 Start watching this issue