I applied the patch, then sync-ed up to current state and the patch appears ok to me...In fact, now seems necessary to get a correct javadoc when building with 1.5.
I saw 1 extra warning when building with ibm 1.5:
[javadoc] C:\derbyt\svn\trunk\java\client\org\apache\derby\jdbc\ClientBaseDataSource.java:1074: warning - Tag @see: reference not found: ClientConnectionPoolDataSource
This warning doesn't show up when building with ibm1.6.
(there's one other warning, [javadoc] C:\derbyt\svn\trunk\java\testing\org\apache\derbyTesting\functionTests\tests\jdbc4\ClobTest.java:333: warning - @param argument "parameterTypes" is not a parameter name. , but that's caused by commit r733725 by Kristian (no JIRA) and happens with both 1.5 and 1.6...)