Attaching a new patch (
DERBY-3829_m5.diff) which attempts to address the permissions problem I saw on windows.
Turns out sysinfo needs read access to org.apache.derby.info.DBMS.properties. If we're using jars, that's in derby.jar, and I guess permission is already granted (I didn't double check that, it seemed logical).
I struggled for a while trying to grant java.io.FilePermission read to $derbyTesting.codeclasses, but that one uses the actual OS's file separator and the FilePermission needs the forward slash - or so it seemed empirically.
So the latest patch adds a property to just the SysinfoTest.policy and wraps that property into a SystemProperty Setup around the test's networkserver setup if we're using classes.
I think there are some other tests that just return an empty suite if we're running with classes for similar reasons, but I thought it worthwhile to make it work as we're already using a decidated policy file.
I svn updated before building this patch and tried to incorporate the recent changes to BaseTestCase.assertExecJavaCmdOK, but I wasn't quite sure that all intended changes were in or not, so a review will be appreciated.
I ran suites.All with jars on linux (no problems), and with classes on windows...On windows I ran twice and got some strange what looked like cleanup-related errors the first time around, especially in the upgrade tests...(warnings like, table already exist etc), but they didn't show up a second time...
All in all, if there are no further suggestions, I'd like to commit this latest variation on Erlend's work...