[DBCP-516] Do not double returnObject back to the pool if there is a transaction context with a shared connection

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6.0
• External issue URL: https://github.com/apache/commons-dbcp/pull/17
• External issue ID: 17
• Assignee: Unassigned
• Reporter: Tom Jenkinson
• Created: 24/Jul/18 10:52
• Updated: 26/Jul/18 07:44
• Resolved: 25/Jul/18 23:28

Description

It is possible for the same thread to return a connection to the pool twice:

// in TX
c = getConnection()
// in aftercompletion
c.getWarnings()
c.getWarnings()

This issue was uncovered after resolving DBCP-515.