[DBCP-515] Do not try to register synchronization when the transaction is no longer active

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6.0
• External issue URL: https://github.com/apache/commons-dbcp/pull/16
• External issue ID: 16
• Assignee: Unassigned
• Reporter: Tom Jenkinson
• Created: 20/Jul/18 10:08
• Updated: 26/Jul/18 07:44
• Resolved: 25/Jul/18 23:12

Description

The current code can try to register a synchronization with the transaction manager when the only transaction on the thread is already committed (e.g. if someone tries to call getConnection in aftercompletion. We should not try to register at that point as it is invalid.