Uploaded image for project: 'Commons DBCP'
  1. Commons DBCP
  2. DBCP-441

Update DBCP2 configuration web page to add missing properties from BasicDataSource API and BasicDataSourceFactory config

    XMLWordPrintableJSON

    Details

      Description

      This web page documents DBCP 2 configuration properties:

      http://commons.apache.org/proper/commons-dbcp/configuration.html

      I compared the listed properties to DBCP 2.1 classes BasicDataSource and BasicDataSourceFactory. I noticed 5 configuration properties supported by the code which are missing from the DBCP configuration web page. Please add these properties to the configuration documentation. Thank you.

      1) jmxName - mentioned in DBCP-418, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page

      2) enableAutoCommitOnReturn - mentioned in DBCP-351, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page

      3) rollbackOnReturn - mentioned in DBCP-399 and DBCP-436, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page

      4) validationQueryTimeout - mentioned in DBCP-163 and DBCP-226, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page

      5) defaultQueryTimeout - mentioned in DBCP-340, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page

      Note: I also noticed BasicDataSource API supports setAbandonedUsageTracking which passes a configuration option to Commons Pool 2. This option is only available in BasicDataSource API, not in BasicDataSourceFactory config, so I am not sure if it was intentionally left out of BasicDataSourceFactory and the DBCP configuration web page.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              justincranford@hotmail.com Justin Cranford
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: