[DBCP-441] Update DBCP2 configuration web page to add missing properties from BasicDataSource API and BasicDataSourceFactory config

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1
• Fix Version/s: 2.1.1
• Labels: documentation easyfix

Environment

http://commons.apache.org/proper/commons-dbcp/configuration.html

• Assignee: Unassigned
• Reporter: Justin Cranford
• Created: 16/Jul/15 19:05
• Updated: 07/Aug/15 03:41
• Resolved: 02/Aug/15 22:50

Description

This web page documents DBCP 2 configuration properties:

http://commons.apache.org/proper/commons-dbcp/configuration.html

I compared the listed properties to DBCP 2.1 classes BasicDataSource and BasicDataSourceFactory. I noticed 5 configuration properties supported by the code which are missing from the DBCP configuration web page. Please add these properties to the configuration documentation. Thank you.

1) jmxName - mentioned in DBCP-418, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page

2) enableAutoCommitOnReturn - mentioned in DBCP-351, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page

3) rollbackOnReturn - mentioned in DBCP-399 and DBCP-436, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page

4) validationQueryTimeout - mentioned in DBCP-163 and DBCP-226, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page

5) defaultQueryTimeout - mentioned in DBCP-340, supported by both BasicDataSource and BasicDataSourceFactory, but not documented on the DBCP configuration web page

Note: I also noticed BasicDataSource API supports setAbandonedUsageTracking which passes a configuration option to Commons Pool 2. This option is only available in BasicDataSource API, not in BasicDataSourceFactory config, so I am not sure if it was intentionally left out of BasicDataSourceFactory and the DBCP configuration web page.