Uploaded image for project: 'Commons DBCP'
  1. Commons DBCP
  2. DBCP-436

Avoid executing ROLLBACK when transaction is not active

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Won't Fix
    • None
    • 2.3.0

    Description

      rollbackOnReturn terminates the transaction by calling rollback on the connection as it is returned to the pool.

      It hurts performance.

      I suggest to don't call rollback if transaction is not active.

      Such improvement is done in HikariCP:
      https://github.com/brettwooldridge/HikariCP/issues/177

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            mihasik Michael Mikhulya
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment