Uploaded image for project: 'Commons DBCP'
  1. Commons DBCP
  2. DBCP-423

PoolingDataSource should implement Closeable

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.1
    • Labels:
      None

      Description

      Currently PoolingDataSource only implements DataSource.

      I have the following case in ops4j pax-jdbc. I offer a DataSourceFactory in one bundle that can create a pooling DataSource.

      Then in another bundle I create DataSources based on config in ConfigurationAdmin. So when the config appears I create the DataSource, when the config goes away I have to destroy it.

      It is important to correctly dispose the DataSource as the pool has to be closed. As I can not depend on dbcp in the bundle that destroys the DataSource I currently have no simple way to destroy the DataSource.

      This is where I create the DataSource:
      https://github.com/ops4j/org.ops4j.pax.jdbc/blob/master/pax-jdbc-pool/src/main/java/org/ops4j/pax/jdbc/pool/impl/PooledDataSourceFactory.java

      I was able to solve it by a kind of hack. I extended the PoolingDataSource with a class that supports Closeable. So from the other bundle I could check if the object implements Closeable and call close.

      It would be a lot easier if PoolingDataSource would implement Closeable like I did. The same is true for GenericObjectPool and the other pools. If they would implement Closeable then handling them would be a lot easier.
      They already support a close method so it would be a small change.


      public class CloseablePoolingDataSource<C extends Connection> extends PoolingDataSource<C> implements Closeable {

      public CloseablePoolingDataSource(ObjectPool<C> pool)

      { super(pool); }

      @Override
      public void close() throws IOException

      { getPool().close(); }

      }

        Attachments

        1. DBCP-423.patch
          4 kB
          Thomas Neidhart

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              cschneider Christian Schneider
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: