Uploaded image for project: 'Commons DBCP'
  1. Commons DBCP
  2. DBCP-337

equals in DelegatingXXX is not reflexive and could be faster

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.3.1, 1.4.1
    • None

    Description

      The equals() methods in the different DelegatingXXX classes do not start with a simple object equality check for this.
      The equals methods do not implement the contract for equals because x.equals where getInnermostDelegate() for x returns null will return false.
      Performance-wise the check would help since you don't need to walk the delegate tree.

      I will attach a patch.

      Rob

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            rgansevles Rob Gansevles
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment