Uploaded image for project: 'Commons DBCP'
  1. Commons DBCP
  2. DBCP-337

equals in DelegatingXXX is not reflexive and could be faster

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.1, 1.4.1
    • Labels:
      None

      Description

      The equals() methods in the different DelegatingXXX classes do not start with a simple object equality check for this.
      The equals methods do not implement the contract for equals because x.equals where getInnermostDelegate() for x returns null will return false.
      Performance-wise the check would help since you don't need to walk the delegate tree.

      I will attach a patch.

      Rob

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              rgansevles Rob Gansevles

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment