Uploaded image for project: 'Commons DBCP'
  1. Commons DBCP
  2. DBCP-319

Make private fields final where possible

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Labels:
      None

      Description

      Several private fields could be made final:

      AbandonedTrace.config
      AbandonedTrace.AbandonedObjectException._createdTime

      cpdsadapter.PooledConnectionImpl:

      • connection
      • delegatingConnection
      • eventListeners
      • statementEventListeners
      • pstmtPool is protected, but could probably be made final if it were not for the API change that would imply

      cpdsadapter.PooledConnectionImpl.PStmtKey (nested class, variables are protected, but might as well be private)

      • all of its fields could be made final

      datasources.[Keyed]CPDSConnectionFactory.validatingMap
      datasources.[Keyed]CPDSConnectionFactory.pcMap

      managed.PoolableManagedConnection.transactionRegistry
      managed.PoolableManagedConnectionFactory.transactionRegistry

      managed.TransactionRegistry.transactionManager|caches|xaResources
      .AbandonedObjectPool.config|trace

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sebb Sebb
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: