[DBCP-319] Make private fields final where possible

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 07/Jan/10 00:26
• Updated: 31/May/14 04:14
• Resolved: 09/Dec/13 20:47

Description

Several private fields could be made final:

AbandonedTrace.config
AbandonedTrace.AbandonedObjectException._createdTime

cpdsadapter.PooledConnectionImpl:

• connection
• delegatingConnection
• eventListeners
• statementEventListeners
• pstmtPool is protected, but could probably be made final if it were not for the API change that would imply

cpdsadapter.PooledConnectionImpl.PStmtKey (nested class, variables are protected, but might as well be private)

• all of its fields could be made final

datasources.[Keyed]CPDSConnectionFactory.validatingMap
datasources.[Keyed]CPDSConnectionFactory.pcMap

managed.PoolableManagedConnection.transactionRegistry
managed.PoolableManagedConnectionFactory.transactionRegistry

managed.TransactionRegistry.transactionManager|caches|xaResources
.AbandonedObjectPool.config|trace