[DBCP-317] Findbugs: Class doesn't override equals in superclass

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 05/Jan/10 02:35
• Updated: 24/Feb/15 03:23
• Resolved: 04/Feb/14 13:46

Description

Findbugs: Class doesn't override equals in superclass - 8 instances

"This class extends a class that defines an equals method and adds fields, but doesn't define an equals method itself. Thus, equality on instances of this class will ignore the identity of the subclass and the added fields. Be sure this is what is intended, and that you don't need to override the equals method. Even if you don't need to override the equals method, consider overriding it anyway to document the fact that the equals method for the subclass just return the result of invoking super.equals(o). "

Classes (superclass) are:

cpdsadapter.ConnectionImpl doesn't override DelegatingConnection.equals
datasources.LRUMap doesn't override SequencedHashMap.equals
managed.ManagedConnection doesn't override DelegatingConnection.equals
managed.PoolableManagedConnection doesn't override DelegatingConnection.equals
PoolableCallableStatement doesn't override DelegatingCallableStatement.equals
PoolableConnection doesn't override DelegatingConnection.equals
PoolablePreparedStatement doesn't override DelegatingPreparedStatement.equals
PoolingConnection doesn't override DelegatingConnection.equals

Issue Links

• duplicates: DBCP-358 Equals implementations in DelegatingXxx classes are not symmetric