Uploaded image for project: 'Commons DBCP'
  1. Commons DBCP
  2. DBCP-317

Findbugs: Class doesn't override equals in superclass

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.4
    • 2.0
    • None

    Description

      Findbugs: Class doesn't override equals in superclass - 8 instances

      "This class extends a class that defines an equals method and adds fields, but doesn't define an equals method itself. Thus, equality on instances of this class will ignore the identity of the subclass and the added fields. Be sure this is what is intended, and that you don't need to override the equals method. Even if you don't need to override the equals method, consider overriding it anyway to document the fact that the equals method for the subclass just return the result of invoking super.equals(o). "

      Classes (superclass) are:

      cpdsadapter.ConnectionImpl doesn't override DelegatingConnection.equals
      datasources.LRUMap doesn't override SequencedHashMap.equals
      managed.ManagedConnection doesn't override DelegatingConnection.equals
      managed.PoolableManagedConnection doesn't override DelegatingConnection.equals
      PoolableCallableStatement doesn't override DelegatingCallableStatement.equals
      PoolableConnection doesn't override DelegatingConnection.equals
      PoolablePreparedStatement doesn't override DelegatingPreparedStatement.equals
      PoolingConnection doesn't override DelegatingConnection.equals

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            sebb Sebb
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment