[DBCP-358] Equals implementations in DelegatingXxx classes are not symmetric

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2, 1.2.2, 1.3, 1.4
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: Phil Steitz
• Created: 28/Apr/11 22:14
• Updated: 31/May/14 04:13
• Resolved: 04/Feb/14 13:45

Description

For reasons unclear to me, DelegatingConnection, DelegatingStatement, PoolGuardConnectionWrappers and other DBCP classes implement equals so that the wrapping class is considered equal to its innermost delegate JDBC object. This makes equals asymmetric when applied to a wrapper and its wrapped JDBC object - wrapper.equals(delegate) returns true, but delegate.equals(wrapper) will in general return false.

I am pretty sure that DBCP itself does not rely on this bugged behavior, so I am inclined to fix it, making equals an equivalence relation on wrapper instances, with two considered equal iff their innermost delegates are equal. I can't imagine use cases where the bugged behavior is required. Can anyone else?

Issue Links

• breaks: DBCP-356 ManagedDataSource doesn't work with an active transaction in progress on IBM JDK 6+
• is duplicated by: DBCP-317 Findbugs: Class doesn't override equals in superclass